Open
Conversation
…euristic. Co-authored-by: Claude <noreply@anthropic.com>
35f61b6 to
995d0a4
Compare
Member
|
I am okay with this change. But it's a fixed cost that we will have to pay forever and it's not useful on the server side (AFAICT). I'm wondering if there is an alternative, which is for your application where you need itempotency in POST requests, to subclass request, e.g. class IdempotentRequest < Protocol::HTTP::Request
def idempotent?
true
end
endI don't have a strong opinion one way or another, but I'd like to hear your thoughts on this design, the relevance to the server side, and the long term cost of extending the default Request class here, vs the value to users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #99.
Types of Changes
Contribution